Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-js 3.21.4 #177388

Closed
wants to merge 1 commit into from
Closed

protoc-gen-js 3.21.4 #177388

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

release notes 
This release consists of mostly minor changes:

    

  • Documentation link fixes
    • 

  • Updated code generator to work with upstream API changes
    • 

  • Groundwork for moving to Bazel modules

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` autobump labels Jul 15, 2024
@Moisan Moisan added the build failure CI fails while building the software label Jul 15, 2024
@Moisan
Copy link
Member

Moisan commented Jul 15, 2024 

  ERROR: /private/tmp/protoc-gen-js-20240715-4848-ktlwad/protobuf-javascript-3.21.3/generator/BUILD.bazel:1:10: Compiling generator/protoc-gen-js.cc failed: (Exit 1): cc_wrapper.sh failed: error executing CppCompile command (from target //generator:protoc-gen-js) external/local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics ... (remaining 151 arguments skipped)
  
  Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
  generator/protoc-gen-js.cc:31:10: error: module //generator:protoc-gen-js does not depend on a module exporting 'google/protobuf/compiler/plugin.h'
  #include <google/protobuf/compiler/plugin.h>
           ^
  1 error generated.

The issue is known upstream: protocolbuffers/protobuf-javascript#214

@chenrui333 chenrui333 force-pushed the bump-protoc-gen-js-3.21.3 branch from 3116cd2 to da2a576 Compare July 15, 2024 20:54
@chenrui333 chenrui333 changed the title protoc-gen-js 3.21.3 protoc-gen-js 3.21.4 Jul 15, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software automerge-skip `brew pr-automerge` will skip this pull request labels Jul 15, 2024
@luangong
Copy link
Contributor

luangong commented Jul 16, 2024 •
edited
Loading

protoc-gen-js 3.21.4 now depends on protobuf instead of protobuf@21.

@chenrui333 @branchvincent
protoc-gen-js 3.21.4
3e1acf1 
Signed-off-by: Rui Chen <[email protected]>

autobump: add protoc-gen-js

Signed-off-by: Rui Chen <[email protected]>
@branchvincent branchvincent force-pushed the bump-protoc-gen-js-3.21.3 branch from da2a576 to 3e1acf1 Compare July 16, 2024 02:42
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 18, 2024
@luangong
Copy link
Contributor

luangong commented Jul 18, 2024 •
edited
Loading

It seems that protoc-gen-grpc-web depends on protoc-gen-js and protobuf, so we should update them in the same commit, but a new release of protoc-gen-grpc-web that depends on protobuf 27.1 is not yet ready.

See grpc/grpc-web#1445.

@chenrui333
Copy link
Member Author

yeah, that is what I saw as well, might be good just close the PR and wait for the protoc-gen-grpc-web update and get everything in the protobuf 27 land.

@chenrui333 chenrui333 closed this Jul 18, 2024
@chenrui333 chenrui333 deleted the bump-protoc-gen-js-3.21.3 branch July 18, 2024 13:34
@chenrui333
Copy link
Member Author

@luangong feel free to drop new PR once you see ready.

@chenrui333 chenrui333 added blocked and removed ready to merge PR can be merged once CI is green labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request blocked bump-formula-pr PR was created using `brew bump-formula-pr` stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @Moisan @luangong